Comments on: fillcode http://snarfed.org Ryan Barrett's blog Fri, 18 May 2012 05:50:35 +0000 hourly 1 By: hober http://snarfed.org/fillcode#comment-420 hober Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-420 <p>FYI, fillcode.el doesn't work with the python.el in CVS Emacs.</p> FYI, fillcode.el doesn’t work with the python.el in CVS Emacs.

]]> By: ryan http://snarfed.org/fillcode#comment-421 ryan Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-421 <p>thanks for the feedback! ay, really, it doesn't? i've been testing with python-mode 4.6.18.2, and it works ok.</p> <p class="paragraph"/> <p>would you mind describing in more detail what doesn't work with the python-mode in CVS?</p> thanks for the feedback! ay, really, it doesn’t? i’ve been testing with python-mode 4.6.18.2, and it works ok.

would you mind describing in more detail what doesn’t work with the python-mode in CVS?

]]> By: ryan http://snarfed.org/fillcode#comment-422 ryan Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-422 <p>in python-mode, one problem with the original fillcode i posted was that it often filled more than just the single statement under point. i've posted a new version that is much better (and thus more polite) about determining where the current statement ends.</p> <p class="paragraph"/> <p>thanks for the bug report!</p> in python-mode, one problem with the original fillcode i posted was that it often filled more than just the single statement under point. i’ve posted a new version that is much better (and thus more polite) about determining where the current statement ends.

thanks for the bug report!

]]> By: hober http://snarfed.org/fillcode#comment-423 hober Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-423 <p><pre>Debugger entered--Lisp error: (void-function py-in-literal) py-in-literal() funcall(py-in-literal) (or (funcall in-literal-fn) (eval (cons … ...))) (let ((in-literal-fn ...) (literal-start-tokens ...)) (or (funcall in-literal-fn) (eval ...))) fillcode-in-literal() (cond ((fillcode-in-literal) (forward-char)) ((eolp) (delete-indentation t)) ((looking-at ...) (delete-horizontal-space) (if … ...)) ((and … ...) (progn … ...)) ((and … ... ...) (progn … ...)) (t (forward-char))) fillcode-collapse-whitespace-forward() fillcode() call-interactively(fillcode) execute-extended-command(nil) call-interactively(execute-extended-command)</pre></p> <pre>Debugger entered–Lisp error: (void-function py-in-literal) py-in-literal() funcall(py-in-literal) (or (funcall in-literal-fn) (eval (cons … …))) (let ((in-literal-fn …) (literal-start-tokens …)) (or (funcall in-literal-fn) (eval …))) fillcode-in-literal() (cond ((fillcode-in-literal) (forward-char)) ((eolp) (delete-indentation t)) ((looking-at …) (delete-horizontal-space) (if … …)) ((and … …) (progn … …)) ((and … … …) (progn … …)) (t (forward-char))) fillcode-collapse-whitespace-forward() fillcode() call-interactively(fillcode) execute-extended-command(nil) call-interactively(execute-extended-command)</pre>

]]> By: hober http://snarfed.org/fillcode#comment-424 hober Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-424 <p>(python.el in CVS Emacs is completely different than python-mode.el from python.org.)</p> (python.el in CVS Emacs is completely different than python-mode.el from python.org.)

]]> By: ryan http://snarfed.org/fillcode#comment-425 ryan Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-425 <p>yeah, i do remember that. sigh. thanks for the info.</p> <p class="paragraph"/> <p>i just downloaded and built CVS emacs, and it breaks the fillcode unit tests spectacularly. that'll be a good place for me to start.</p> yeah, i do remember that. sigh. thanks for the info.

i just downloaded and built CVS emacs, and it breaks the fillcode unit tests spectacularly. that’ll be a good place for me to start.

]]> By: ashawley http://snarfed.org/fillcode#comment-426 ashawley Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-426 <p>Rather than defining a mode and using hooks you can just set <code>fill-paragraph-function' to the desired "fillcode" function. See the command help on</code>fill-paragraph' at `C-h f fill-paragraph'.</p> Rather than defining a mode and using hooks you can just set fill-paragraph-function' to the desired "fillcode" function. See the command help onfill-paragraph’ at `C-h f fill-paragraph’.

]]> By: ryan http://snarfed.org/fillcode#comment-427 ryan Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-427 <p>good point. that's true for all major modes that respect <code>fill-paragraph-function'.<p class="paragraph"/>unfortunately, cc-mode doesn't. it replaces</code>fill-paragraph' with <code>c-fill-paragraph', which it binds M-q to.</code>c-fill-paragraph' ignores <code>fill-paragraph-function' entirely. :/<p class="paragraph"/>so, for fillcode to work in cc-mode major modes, it has to do something like advise</code>c-fill-paragraph'...which it does. still, you're probably right, it doesn't need a whole minor mode. i'll consider removing that in the future.</p> good point. that’s true for all major modes that respect fill-paragraph-function'.<p class="paragraph"/>unfortunately, cc-mode doesn't. it replacesfill-paragraph’ with c-fill-paragraph', which it binds M-q to.c-fill-paragraph’ ignores fill-paragraph-function' entirely. :/<p class="paragraph"/>so, for fillcode to work in cc-mode major modes, it has to do something like advisec-fill-paragraph’…which it does. still, you’re probably right, it doesn’t need a whole minor mode. i’ll consider removing that in the future.

]]> By: MartinG http://snarfed.org/fillcode#comment-428 MartinG Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-428 <p>Thanks for this very nice emacs mode!<br /> <br /> I think I found one bug though - when filling this string:<br />   <code>for (iy = 0; iy < dLy; iy++)</code><br /> it becomes<br />   <code>for (iy = 0; iy < dLy; iy+ +)</code><br /> i.e. it separates the "+" signs. This is in cc-mode.</p> Thanks for this very nice emacs mode!

I think I found one bug though – when filling this string:
  <code>for (iy = 0; iy < dLy; iy++)</code>
it becomes
  <code>for (iy = 0; iy < dLy; iy+ +)</code>
i.e. it separates the “+” signs. This is in cc-mode.

]]> By: Vomicae http://snarfed.org/fillcode#comment-429 Vomicae Wed, 30 Nov -0001 00:00:00 +0000 http://snarfed.org/wordpress/fillcode#comment-429 <p>Fillcode is Perl the best</p> Fillcode is Perl the best

]]>